-
-
Notifications
You must be signed in to change notification settings - Fork 288
improving the background of reactions with added contrast #5522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@rapterjet2004 how about always having a border on the reaction items? That way we don't waste extra space for margins and paddings? |
|
Would also be closer to the the web UI, no? |
i agree always having a border on the items will be nicer (instead for the whole LinearLayout). This is how it looks on web and we should do it similar on clients:
|
|
Good call on separating the reactions! Agreed that a border for all together looks a bit off though. We could go for a light background for each reaction, and for the ones the user has reacted with we can do primary colored border with a stronger background :) |
|
@rapterjet2004 can you also add the "before" state, to have a better comparison if the color schema is "correct"? Thanks in advance |
^ @rapterjet2004 can you update the screenshots & rebase? |
Signed-off-by: rapterjet2004 <[email protected]>
9d6d4cb to
4d693eb
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5522.apk |
|
Fine by me as an iteration to improve the display of reactions. Mid-term for mobile I think we should pin them vertically centered on the bottom of the bubble like other messengers. Also but debatable of course only show the number if it is "more than 1". What do you think @nimishavijay |


🖼️ Screenshots Before
🖼️ Screenshots After
🏁 Checklist
/backport to stable-xx.x